* Check for Possible Duplicated Media; Plugin Error

For users to report plugin bugs and request plugin enhancements; and for authors to test new/new versions of plugins, and to discuss plugin development (in the Programming Technicalities sub-forum). If you want advice on choosing or using a plugin, please ask in General Usage or an appropriate sub-forum.
Post Reply
avatar
peterbel
Superstar
Posts: 301
Joined: 21 Nov 2014 20:24
Family Historian: V7
Location: Cornwall

Check for Possible Duplicated Media; Plugin Error

Post by peterbel » 07 Dec 2022 10:22

Version 1.3.4.
FH 7. 0.18
Win10
Almost at the very end of the 'run' this error comes up. Is there something I can do to correct it?
Plugin Error.JPG
Plugin Error.JPG (48.54 KiB) Viewed 458 times
Tracing the Devon Bellamy family along with their partners.

User avatar
ColeValleyGirl
Megastar
Posts: 4853
Joined: 28 Dec 2005 22:02
Family Historian: V7
Location: Cirencester, Gloucestershire
Contact:

Re: Check for Possible Duplicated Media; Plugin Error

Post by ColeValleyGirl » 07 Dec 2022 10:41


User avatar
tatewise
Megastar
Posts: 27077
Joined: 25 May 2010 11:00
Family Historian: V7
Location: Torbay, Devon, UK
Contact:

Re: Check for Possible Duplicated Media; Plugin Error

Post by tatewise » 07 Dec 2022 11:34

Yes, the cause is probably the same but the script line number has changed from around 230 to around 65.
The same function LoadFromFile(...) is involved and the same diagnostics and workaround apply.

My 'prototype' Check for Possible Duplicated Media plugin is only a workaround for the Plugin Store version by Jane, which hopefully will incorporate these fixes and the cache.

Perhaps it should list any large files such as .mp4 that get excluded form the duplicated check?
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

User avatar
Mark1834
Megastar
Posts: 2146
Joined: 27 Oct 2017 19:33
Family Historian: V7
Location: South Cheshire, UK

Re: Check for Possible Duplicated Media; Plugin Error

Post by Mark1834 » 07 Dec 2022 13:03

Wasn't there also discussion about speeding up the runtime by simply checking file size? You only need to do the memory-intensive MD5 calculation if the files are of identical size. If size differs, they cannot be duplicates.
Mark Draper

User avatar
tatewise
Megastar
Posts: 27077
Joined: 25 May 2010 11:00
Family Historian: V7
Location: Torbay, Devon, UK
Contact:

Re: Check for Possible Duplicated Media; Plugin Error

Post by tatewise » 07 Dec 2022 14:44

I don't recall that discussion but it is undoubtedly a good idea. Hopefully, Jane is monitoring this discussion.
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

avatar
peterbel
Superstar
Posts: 301
Joined: 21 Nov 2014 20:24
Family Historian: V7
Location: Cornwall

Re: Check for Possible Duplicated Media; Plugin Error

Post by peterbel » 07 Dec 2022 22:00

Thanks everyone.
I briefly read the referenced thread and the code before I went out this morning and registered the current position for the print statement to be added.
Altering and running the PlugIn this evening showed the problem was two .avi files, moving them solved the problem.
Tracing the Devon Bellamy family along with their partners.

Post Reply