* Change any Fact plugin

For users to report plugin bugs and request plugin enhancements; and for authors to test new/new versions of plugins, and to discuss plugin development (in the Programming Technicalities sub-forum). If you want advice on choosing or using a plugin, please ask in General Usage or an appropriate sub-forum.
Post Reply
avatar
johnhanson
Diamond
Posts: 62
Joined: 27 Nov 2002 16:50
Family Historian: V7
Contact:

Change any Fact plugin

Post by johnhanson » 16 Nov 2022 10:32

I am trying to help a friend sort out his import from TMG and struggling to get this plug-in to work

Facts.jpg
Facts.jpg (156.46 KiB) Viewed 2316 times

The list of fact might give an idea of the issue and I going to go into lengthy discussions as to why as not really relevant

I am trying to change each of the census entries to the standard Census

Change-Fact-Plugin.jpg
Change-Fact-Plugin.jpg (86.69 KiB) Viewed 2316 times

I was certain that I had this correct (and appears to be from the help) but the button is not changing to enable it to work

Can someone explain what I am doing wrong?
Last edited by tatewise on 16 Nov 2022 12:00, edited 1 time in total.
Reason: Corrected image presentation
John Hanson
Researcher, the Halsted Trust

User avatar
LornaCraig
Megastar
Posts: 2989
Joined: 11 Jan 2005 17:36
Family Historian: V7
Location: Oxfordshire, UK

Re: Change any Fact plugin

Post by LornaCraig » 16 Nov 2022 11:49

I'm sure Mike will reply soon, but meanwhile have a look at this topic Error when running 'Change Any Fact Tag' (20800).
Mike identified a problem which was caused by local Project Fact Sets (such as imported sets) having higher precedence than system Fact Sets. In his last post in that topic he attached an updated Version 3.6.3 Date 10 Nov 2022 which may not be in the plugin store yet.
Last edited by tatewise on 16 Nov 2022 12:01, edited 1 time in total.
Reason: Improved topic link
Lorna

User avatar
tatewise
Megastar
Posts: 27077
Joined: 25 May 2010 11:00
Family Historian: V7
Location: Torbay, Devon, UK
Contact:

Re: Change any Fact plugin

Post by tatewise » 16 Nov 2022 12:02

Yes, Lorna has identified the problem and the solution.
I am about to publish that updated version in the Plugin Store today.
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

avatar
johnhanson
Diamond
Posts: 62
Joined: 27 Nov 2002 16:50
Family Historian: V7
Contact:

Re: Change any Fact plugin

Post by johnhanson » 16 Nov 2022 13:39

Thanks both
Be interesting to see how it copes with a database of 65,000 people and 135,000 facts
John Hanson
Researcher, the Halsted Trust

User avatar
tatewise
Megastar
Posts: 27077
Joined: 25 May 2010 11:00
Family Historian: V7
Location: Torbay, Devon, UK
Contact:

Re: Change any Fact plugin

Post by tatewise » 16 Nov 2022 16:10

I've just run it on 36K Individual records with 234K facts to make 2K changes and it took less than a minute on my 'slow' PC.
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

avatar
johnhanson
Diamond
Posts: 62
Joined: 27 Nov 2002 16:50
Family Historian: V7
Contact:

Re: Change any Fact plugin

Post by johnhanson » 16 Nov 2022 17:06

Mike
Downloaded the new version and works fine
However, whilst it is processing progress bar reaches 100% at individual ID's around 8000 but there are 65,000 in the database
It carries on and some might be concerned as to what it is processing when it says that it is complete
Change-Fact-Plugin1.jpg
Change-Fact-Plugin1.jpg (23.14 KiB) Viewed 2234 times
John Hanson
Researcher, the Halsted Trust

User avatar
tatewise
Megastar
Posts: 27077
Joined: 25 May 2010 11:00
Family Historian: V7
Location: Torbay, Devon, UK
Contact:

Re: Change any Fact plugin

Post by tatewise » 16 Nov 2022 18:16

Ah, sorry! Yes, that bug seems to have existed for a while. It will be fixed in the next update.
It was a small typo in one line of the script!
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

avatar
Woodg
Famous
Posts: 119
Joined: 08 Oct 2019 09:28
Family Historian: V7
Location: Orange, Australia

Re: Change any Fact plugin

Post by Woodg » 16 Nov 2022 19:08

Hi Mike,

I was testing your new version of the Change Any Fact plugin (so I could update my conversion notes) and I discovered an issue that I suspect is applicable to all plugins and not just Change Any Facts (and may very well be a known issue). If you run the plugin and select Change all the rest so that you don't need to confirm each change, and you happen get lots of Warnings (as I did) then you can't break or cancel out of the process. You have to click on Close Warning for each warning until the process completes (about 300 times for me).

Now, I only found this because I had forgotten to clean up some extra TAGS from the GEDCOM import, so the warnings were for TAGS that FH7 didn't like. It's entirely possible that I'll not have this issue again (as I hope not to make the same silly mistake again), but other users might.

I could have used Task Manager to stop the FH7 process but that really is a last resort. Is there another way to close the plugin?

Glenn

User avatar
tatewise
Megastar
Posts: 27077
Joined: 25 May 2010 11:00
Family Historian: V7
Location: Torbay, Devon, UK
Contact:

Re: Change any Fact plugin

Post by tatewise » 16 Nov 2022 20:27

I think I have experienced that before and overlooked a fix. :oops:
It should be possible to fix by adding an extra button to the warning dialogue. It will be in the next version. :D
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

avatar
Woodg
Famous
Posts: 119
Joined: 08 Oct 2019 09:28
Family Historian: V7
Location: Orange, Australia

Re: Change any Fact plugin

Post by Woodg » 16 Nov 2022 22:01

Thanks Mike. It's nice to know that you're human and not an FH bot! :D

Glenn

avatar
johnhanson
Diamond
Posts: 62
Joined: 27 Nov 2002 16:50
Family Historian: V7
Contact:

Re: Change any Fact plugin

Post by johnhanson » 16 Nov 2022 22:47

Mike
Thanks - wasn't a show-stopper but just annoying
Keep up the good work
John Hanson
Researcher, the Halsted Trust

avatar
Woodg
Famous
Posts: 119
Joined: 08 Oct 2019 09:28
Family Historian: V7
Location: Orange, Australia

Re: Change any Fact plugin

Post by Woodg » 17 Nov 2022 06:19

Hi Mike,

I've just found an issue with this plugin.

Steps to recreate:
1 Run plugin
2 Select the Pick records option to open the Pick window
3 Change your mind and close the plugin window before closing the Pick window
4 Close the Pick window
5 FH "freezes" and no options of any kind can be selected

The Plugin box shows the particular plugin is still running but now there is no way to stop the plugin.

The only way to get FH working again is to close it using Task Manager.

I only discovered this issue as I used Alt-Tab to change windows.

In further testing I found the Create Individual Shortcut has the same issue but the Search and Replace plugin doesn't let you close the plugin window if the Pick window is still open.

Glenn

User avatar
Mark1834
Megastar
Posts: 2146
Joined: 27 Oct 2017 19:33
Family Historian: V7
Location: South Cheshire, UK

Re: Change any Fact plugin

Post by Mark1834 » 17 Nov 2022 10:39

I can reproduce that. Multiple windows in plugins can be a tricky thing to get right, as the user interface tool is extremely unforgiving. I've lost count of the number of times I've frozen or crashed FH in testing!
Mark Draper

User avatar
tatewise
Megastar
Posts: 27077
Joined: 25 May 2010 11:00
Family Historian: V7
Location: Torbay, Devon, UK
Contact:

Re: Change any Fact plugin

Post by tatewise » 17 Nov 2022 12:18

Ah! Nice find.
The solution is to make the IUP main dialogue inactive during the Record Selection prompt by using:

Code: Select all

dialogMain.Active="No"
arrRec = fhPromptUserForRecordSel(strType)
dialogMain.Active="Yes"
The Search and Replace plugin does that, but Change Any Fact Tag does not, but will in the next version :D

Alternative ways of making parent dialogues inactive are discussed in Modal window techniques (21192).

Try the attached Change Any Fact Tag plugin Version 3.7.1 Date 17 Nov 2022 which should fix all the recent issues.
Last edited by tatewise on 24 Nov 2022 15:41, edited 1 time in total.
Reason: Attachment deleted as later version is in the Plugin Store.
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

User avatar
tatewise
Megastar
Posts: 27077
Joined: 25 May 2010 11:00
Family Historian: V7
Location: Torbay, Devon, UK
Contact:

Re: Change any Fact plugin

Post by tatewise » 24 Nov 2022 12:58

Change Any Fact Tag plugin Version 3.8 Date 24 Nov 2022 is in the Plugin Store and the prototype below will soon be deleted.
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

Post Reply