Cleanup Notes 1.2

ronk · Post by **ronk** » 02 Feb 2021 02:48

I did a a test of Cleanup Notes 1.2 just released for FH 7. and did an export immediately after. I then compared a gedcom exported before and after running the plugin. The results were identical, except, several source citations to local notes were inexplicably removed from the output, so I have reverted to a backup. It did correctly remove a couple blank lines at front end of some local notes.

Brings up a simple question. In FH, how to I quickly see all citations for a given source? In TNG, I merely click on the source and links are displayed. I click on Source tab, and it shows how many citations, but no list link.

jbtapscott · Post by **jbtapscott** » 02 Feb 2021 06:37

Select your Source record and then, on the menu, select View / Citations to Source Record

YouTube · Post by **Jane** » 02 Feb 2021 09:17

If possible to send me a copy of the file before you ran it with details of which notes were lost.

ronk · Post by **ronk** » 02 Feb 2021 12:44

Hi Jane,

It wasn't notes that were lost, but a few citations to notes. I wasn't sure how to send files to you on FHUG. Clicking email doesn't seem to permit it. I have inserted an image of all differences from BeyondCompare of both exported gedcoms, which isn't of much use without the actual files, but just to show types of records altered before/after. The right side is an export before running Cleanup Notes, the left after. Note that two of the changes are mine: addition of children, and the prefix 'I' to 'P' change in the four urls. Also included is a blowup of detail around the lost citation.

***removed since another plugin involved***

Are you asking for the full FH data ged file?

Post by **tatewise** » 02 Feb 2021 13:18

Ron, what manner of export are you using? Export Gedcom File plugin? What target product?

GEDCOM 5.5.1 does not allow Notes to have Citations so the plugin often 'adjusts' them for some products.

ronk · Post by **ronk** » 02 Feb 2021 18:29

Sorry, you're right; I should have included that information. Target was TNG, and the snapshots were showing differences in output using the lastest Export Gedcom File V4.3, before and after the installation and run of Cleanup Notes. 1.2. I could run again to confirm if necessary.

Post by **tatewise** » 02 Feb 2021 20:29

To see the effect of the Cleanup Notes plugin you need to compare the Project GEDCOM before and after, not any export.

Export Gedcom File makes significant changes the GEDCOM to suit the target product as I'm sure you know.

ronk · Post by **ronk** » 02 Feb 2021 21:53

Thanks Mike, yes I took that route to see TNG impact. And if nothing else has changed but the running of Cleanup Notes 1.2, wouldn't the export comparision of changes be caused by that?

I will compare the project gedcom, but I expect the same or similar results.

Post by **tatewise** » 02 Feb 2021 22:37

I take your point, but some of the Export Gedcom File settings have changed recently to accommodate the nuances of Notes with Citations. You have also had some issues with those plugin settings recently. The Plugin tends to remember settings in Projects where it has been used before unless you use the Reset buttons. That can inhibit the corrected settings from taking effect. Whereas, when the Plugin is used in a new Project only the latest settings are applied. So there is some doubt in my mind about whether your two sample exported TNG GEDCOM were created using the same rules.

Comparing the Project GEDCOM can never be in doubt.

ronk · Post by **ronk** » 03 Feb 2021 00:43

OK, so I compared the Project Gedcoms, doing a Gedcom backup before the Cleanup Notes 1.2 execution. The results are essentially the same, with several citations to notes being dropped. The changes otherwise so minor, that I will likely not use this plugin if it has this peculiar result. The BEF is on the left in both snaps.

: snap1.jpg (268.22 KiB) Viewed 3268 times

: snap1.jpg (268.22 KiB) Viewed 3268 times

I wasn't sure how to send the project file for inspection privately. It seemed like private messages to Jane wouldn't permit it.

Post by **tatewise** » 03 Feb 2021 11:28

I have checked the Clean Up Notes plugin and, Ron, you are absolutely correct.
1) It removes all Citations from local Notes!
2) It removes rich text formatting from Notes too!
3) Possible CopyChildBranch needs updating to Copy Child Branch Fields

1) seems to be a bug in the FH API when using fhSetValueAsText(...) to save the Note it removes the Citations.
(This may be a side-effect of Note Citations not strictly being allowed in GEDCOM 5.5.1 but FH does not enforce that.)
I have reported it to CP.

2) is because the plugin is treating Note fields as plain text instead of richtext.

3) may be needed if Note records have templated Citation fields or are rich text.

YouTube · Post by **Jane** » 03 Feb 2021 13:02

I will withdraw the plugin for now until I have time to fix it.

ronk · Post by **ronk** » 03 Feb 2021 14:36

Glad I could be of help debugging; sorry I took an indirect approach to show results first time.

Family Historian User Group

* Cleanup Notes 1.2

Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2

Re: Cleanup Notes 1.2