* Improve Website plugin error

[JP Ford]

Running FH 6.2.7 under POL/Wine, I get the following error:

Code: Select all

[string "C:\ProgramData\Calico Pie\Family Historian\..."]:3035: 

 Could not download icon JPG file from FHUG. 

 http://www.fhug.org.uk/pushfile.php?filename=improve_etc_icon.jpg&name=improve_etc_icon&ns=/plugins/help/improve_html/ 

 C:\ProgramData\Calico Pie\Family Historian\Plugin Data\improve_etc_icon.jpg 
 
stack traceback:
	[C]: in function 'error'
	[string "C:\ProgramData\Calico Pie\Family Historian\..."]:3035: in function 'DownloadIcons'
	[string "C:\ProgramData\Calico Pie\Family Historian\..."]:3366: in function 'IntImproveHTML'
	[string "C:\ProgramData\Calico Pie\Family Historian\..."]:4599: in function <[string "C:\ProgramData\Calico Pie\Family Historian\..."]:4596>
	(tail call): ?
	[C]: in function 'MainLoop'
	[string "C:\ProgramData\Calico Pie\Family Historian\..."]:2261: in function 'ShowDialogue'
	[string "C:\ProgramData\Calico Pie\Family Historian\..."]:4806: in function 'GUI_MainDialogue'
	[string "C:\ProgramData\Calico Pie\Family Historian\..."]:20994: in main chunk

After clicking the "Turn non-image Media Into icons" button in the "Media Popups" tab. Once the error appears, the entire plugin is non-responsive (all gui objects are greyed out) and must be closed and restarted. The same error (with different icon file) occurs when clicking the Covert all URL..." button on the "Hyperlinks/Text" tab.

I can access and download the icon from the site using a browser in my host OS. I'm assuming this is related to the internet access issue with FH and Wine that I've seen mentioned before somewhere... Copying the icon file in question to the "C:\ProgramData\Calico Pie\Family Historian\Plugin Data\i" path has no effect.

Intermittently, (about every 4th time I restart the plugin) I also get this error:

(001).png (9.28 KiB) Viewed 9210 times

Any ideas about a workaround?

[tatewise]

Yes, this is probably related to all the other download issues with WINE based emulators.
There are four icon files to download to:
C:\ProgramData\Calico Pie\Family Historian\Plugin Data\improve_doc_icon.jpg
C:\ProgramData\Calico Pie\Family Historian\Plugin Data\improve_pdf_icon.jpg
C:\ProgramData\Calico Pie\Family Historian\Plugin Data\improve_etc_icon.jpg
C:\ProgramData\Calico Pie\Family Historian\Plugin Data\improve_txt_icon.jpg

The solution, as for library modules, will be a ZIP file of those icons to download to the Plugin Data folder.
I have added how_to:family_historian_v6_on_crossover_wine#plugin_download_files|> Plugin Download Files for those icon files.

See plugins:help:improve_html:nonimageurl|> Improve Website or CD DVD HTML ~ Non-Image Media URL for more details under Icon Files.

The COM exception message is a common feature that can be produced by many of my Plugins as explained in plugins:help:export_gedcom_file:the_faq#how_can_a_subset_selection_of_records_be_exported|> FAQ > What causes "The Internet appears to be inaccessible" message? and is not easy to workaround and will need a script change.
The small boxes indicate characters that are not handled by the OS and are part of the COM exception details.
I cannot remember exactly what they say.
This communication problem sometimes occurs when the www.family-historian.co.uk/lnk/checkpluginversion.php server is temporarily offline and is related to how_to:family_historian_v6_on_crossover_wine#check_installed_plugins_against_the_store|> Check Installed Plugins Against the Store.

[JP Ford]

Thank, Mike. I'll try to work around this and make any changes recommended.

[tatewise]

I hope the Plugin Download Files ZIP file download has fixed the icon files problem.

Is the COM exception still a big problem?
I am surprised you were not getting that problem with Search and Replace and Change Any Fact Tag when checking the popup hints in plugins (17630) yesterday, because they both have EXACTLY the same script for the COM exception.

Colin, if you see this, can you check it with Crossover and POM.

[JP Ford]

Haven't seen the COM error again. Probably server down. Haven't tested plugin yet, but seems to be working now.

[JP Ford]

Just an update on this plugin after the changes here;

After downloading all the icons, I tested the plugin and found that it mostly worked. The "Turn non-image Media into icons" feature was totally unresponsive upon clicking it. Then the plugin greyed out and both the plugin and FH were simply frozen for about a couple of minutes. No progress bar or other indication that anything was happening. I could still move windows around, but all menus, tabs, etc were disabled. When it did return, it simply returned with no output, report or info to suggest that anything had happened.

I closed the plugin and ran the "Find Unlinked Media" plugin which showed me that all my non-image media files were now unlinked. That told me that the "Turn non-image Media into icons" feature had done it's first chore. I then ran Publish>Create a Website, closed that wizard, and re-opened the "Improve Website..." plugin, ran "Convert all media file Popups" per instructions in the KB at plugins:help:improve_html:nonimageurl|> Improve Website or CD DVD HTML ~ Non-Image Media URL. I then ran the "Find Unlinked Media" plugin again and it showed no unlinked media, confirming that all my links had been properly restored.

As to other features, checking the "media list" option never generated anything. So, overall, the plugin will work under POL, but it appears to not be fully functional in every aspect.

[tatewise]

Thank you for that feedback.
If there are more than 100 Media records (of any type) then there should have been a Progress Bar window.
With less than 100 the processing should be so short as to be unnoticeable.
How many Media records are in your Project?

The Plugin does use the http://webserver2.tecgraf.puc-rio.br/im/ Imaging Toolkit to check the format of non-image files, and maybe that runs much slower via POL than in native Windows.

On completion, it should have produced the popup Memo window as shown below.

Maybe the Progress Bar window and Memo window were behind the main Plugin window?
In native Windows they are brought to the front, but maybe POL does not support that Plugin feature.

Sorry, I don't understand what you mean by 'checking the "media list" option'.

Non-ImageMediaMemo.png (29.15 KiB) Viewed 9018 times

[JP Ford]

There are 1000's of media files in my data. I did check to see if other screens were hidden; there were none. POL is nothing but a front-end for Wine, so if Wine supports it, POL supports it. I can confirm that Wine supports all the behaviors noted. Any message window that was created would have shown up either as the active window or behind the active window. There were none, unless they closed themselves after hiding behind the plugin window.

Sorry, I don't understand what you mean by 'checking the "media list" option'.

Sorry about that; I was working from memory (obviously a bad idea). "Checking the 'Media List' option" is befuddle-speak for "Selecting the 'Table of Pictures' on the Content Tables tab". The only thing I could get that tab to generate was a Table of Reports.

[tatewise]

Most of my Plugins have multiple popup windows.
Colin has not reported problems with Crossover, but POM probably needs investigation.

Do the Set Window Fonts and Help & Advice buttons open their respective windows in any of my Plugins?
Does the former window open further windows associated with the upper buttons?

Does the Search and Replace Plugin open a subsidiary window after clicking one of its Search ... buttons?

In Improve Website... the Content Tables tab only creates separate tabs for items in the HOME page Contents table.
So if you have not added Pictures at Step 4 - Add Items for Table of Contents in the Create a Website wizard then there are no entries to create a Table of Pictures tab from. Presumably, at that Step 4 you have added some Reports.
I suppose the Plugin could grey out the tick options that having no matching Table of Contents entries.

[JP Ford]

Most of my Plugins have multiple popup windows. Colin has not reported problems with Crossover, but POM probably needs investigation.

I haven't had any other problems with normal popups and message windows with FH plugins (yours and others) under POL. Only the Improve website one as noted.

Do the Set Window Fonts and Help & Advice buttons open their respective windows in any of my Plugins? Does the former window open further windows associated with the upper buttons?

Yes and Yes.

Does the Search and Replace Plugin open a subsidiary window after clicking one of its Search ... buttons?

and Yes again. Other plugins also provide various response, outcome, progress, warning, etc and all of those work as well under POL.

In Improve Website... the Content Tables tab only creates separate tabs for items in the HOME page Contents table.
So if you have not added Pictures at Step 4 - Add Items for Table of Contents in the Create a Website wizard then there are no entries to create a Table of Pictures tab from. Presumably, at that Step 4 you have added some Reports.

That would explain that.

[tatewise]

I use a shared set of library modules that are included in many of my more complex Plugins.
Most Plugins have been updated to Version 2.9 but Improve Website... is still using Version 2.2.
I cannot say whether that might cause the popup window problems you are seeing, but the window display script has many components within the library modules including the Set Window Fonts and Help & Advice windows.
Interestingly, you say those buttons & windows operate correctly in the Improve Website... Plugin.

I have an unpublished later version of the Improve Website... Plugin that uses library modules Version 2.9.
Try the attached Improve Website... Plugin Version 2.9.1 Date 20 Apr 2020 in compressed ZIP format.
It must be unpacked and the extracted .fh_lua file opened with FH to install it.
Does that fix the Progress Bar and other popup windows?
(You can always download the Plugin Store Version 2.9 to return to what you currently have installed.)
[ EDIT: Attachment deleted as a later version is now published in the Plugin Store. ]

[ColeValleyGirl]

My plugins (MultiFact and Research Planner) use my own standard boilerplate code, not derived from Mike's. Trying those (to determine if they share the same problems or not) might help zero in on the problem causes.

[JP Ford]

My plugins (MultiFact and Research Planner) use my own standard boilerplate code, not derived from Mike's. Trying those (to determine if they share the same problems or not) might help zero in on the problem causes.

I can confirm that Research Planner does not share this issue. Works perfectly once all the prerequisites are in place.

[JP Ford]

... I have an unpublished later version of the Improve Website... Plugin that uses library modules Version 2.9.
Try the attached Improve Website... Plugin Version 2.9.1 Date 20 Apr 2020 in compressed ZIP format.

Mike, I've already shifted over to a VM and dismantled my POL instance for FH. I can and will try this out, but I think it best if I create a new instance of FH with sample data in POL in order to test it out.

[ColeValleyGirl]

Thanks re Research Planner. Mike, do you want to look into the differences? I use iup for message boxes, and not the fh api function.

[tatewise]

Thanks Helen, but I also use iup for virtually all popup boxes, but in particular the Progress Bar uses the standard iup snippet and other popups use iup in Improve Website... just like my other Plugins that seem to work fine.

BTW: It is usually easy to tell the difference because iup windows show the Plugin title & version or some other custom heading, whereas the FH API message box just says Family Historian 6 in the header bar.

I have reviewed the differences between my library V2.2 and V2.9 and the latter version now uses the TopMost="Yes" attribute to put any popup dialogue in front of all other dialogues and that may be the key difference.

It would be useful if Colin sees this and can check how POM and Crossover behave.

[ColeValleyGirl]

OK, Mike, but we must be doing something differently. I'll leave it to you from now on.

[Valkrider]

Thanks Helen, but I also use iup for virtually all popup boxes, but in particular the Progress Bar uses the standard iup snippet and other popups use iup in Improve Website... just like my other Plugins that seem to work fine.

BTW: It is usually easy to tell the difference because iup windows show the Plugin title & version or some other custom heading, whereas the FH API message box just says Family Historian 6 in the header bar.

I have reviewed the differences between my library V2.2 and V2.9 and the latter version now uses the TopMost="Yes" attribute to put any popup dialogue in front of all other dialogues and that may be the key difference.

It would be useful if Colin sees this and can check how POM and Crossover behave.

Mike
I have lost the thread with this post. What plugins do you want me to test?

[tatewise]

Thank you for the offer Colin. It is the Improve Website or CD DVD HTML Plugin.

In POM and probably Crossover check that you need to download icon image files as explained in the how_to:family_historian_v6_on_crossover_wine#plugin_download_files|> Plugin Download Files section.

Also, check the little popup tooltip boxes appear OK when you hover over most buttons and labels.
JP Ford says they appear as black boxes and sometimes flash, until we changed a Balloon setting when they are small rectangular boxes (as in FH).

JP Ford says POL does not produce popup windows in the Media Popups tab when Turn non-image Media into icons is clicked. If there are more 100 Media records then there should be a Progress Bar and at the end a popup message box as illustrated in this thread on Sun 19th Apr 2020 11:34.

If the Plugin Store version fails those checks, is it fixed by the ATTACHMENT earlier today Mon 20th Apr 2020 12:05.

[Valkrider]

Mike I can't get it to run at all in POM. It wants the icon files but can't seem to find them. I have tried them in all the usual places without success. I will have another go in the morning.

Screenshot 2020-04-20 at 20.19.46.png (60.62 KiB) Viewed 8880 times

[tatewise]

Depends on what you mean by all the usual places. Instead of the plugins folder use the plugin data folder.
Previously you put library modules into C:\users\Public\Application Data\Calico Pie\Family Historian/plugins
But the icon image files should go into C:\users\Public\Application Data\Calico Pie\Family Historian/plugin data
See how_to:family_historian_v6_on_crossover_wine#plugin_download_files|> Plugin Download Files for a ZIP file download of 4 icon image files to be unpacked into plugin data.

Is Crossover any different?

[Valkrider]

@Mike

I now have it working in POM.

The instructions in the KB are incorrect.

The four files must be extracted and put in the plugin data folder NOT in a sub folder of improve website icons which is what the zip file extracts to.

I cannot replicate the issue with the tooltips on anything but the tabs. Hovering over other items produces a tooltip in a square box with a grey background. Hovering over the options tab produces a yellow background tooltip with rounded corners that flashes on and off.

I will try Crossover later.

I have never used this plugin before and would be unlikely to use it as I use my own Wordpress plugin for website tree display.

[Valkrider]

JP Ford says POL does not produce popup windows in the Media Popups tab when Turn non-image Media into icons is clicked. If there are more 100 Media records then there should be a Progress Bar and at the end a popup message box as illustrated in this thread on Sun 19th Apr 2020 11:34.

I have just tried the new version in POM on the sample project.

A progress bar popup appears and disappears almost as quickly as there are only 90 media files in the sample project.

No popup window is displayed as per Sunday's thread with either the old or new versions of this plugin.

Still the same tooltip behaviour as above even with this new version.

[tatewise]

I am not sure how to improve the KB download instructions.
All the ZIP downloads in how_to:family_historian_v6_on_crossover_wine#plugin_library_modules|> Plugin Library Modules and how_to:family_historian_v6_on_crossover_wine#plugin_download_files|> Plugin Download Files extract by default into a folder with the same name as the ZIP file.
So, for example:
The pl.zip extracts into a pl folder that contains another pl folder holding the pl files. The inner pl folder goes to plugins.
The zip.zip extracts into a zip folder that contains the zip.dll file. The zip.dll goes directly to plugins.
The improve_website_icons.zip extracts into an improve_website_icons folder that contains 4 icon files. The 4 icon files go to plugin data.
Those extraction folders are just defaults and can be changed in the dialogue to anything anywhere.
They do NOT exist inside the ZIP file itself, so there is nothing that can be changed as part of the zip process.
It is the contents of the extraction folder that must be moved to the necessary FH folder.

It is just like when you download this Plugin Attachment ZIP file it extracts to a folder with the Plugin name by default.
But it is only the contents that matters, i.e. the .fh_lua file.

Following the argument that the extraction folder is wrong, would require every library module download to be called plugins.zip which is possible but does not look right somehow, and the plugin download would have to be called plugin data.zip.

Your feedback regarding tooltip popups confirms a problem with the balloon style that must be avoided in future.
I think if you close and reopen the new attachment Plugin, even the tab tooltips should become rectangular boxes.

When testing the Media Popups tab does the top pane say The HTML folder is valid... or Folder does NOT contain FH V5 or later Website.... If the latter then there is no final popup box ~ I need to check why ~ not sure if the button should even be enabled in that state. However, the fact that you see a Progress Bar popup, albeit briefly, suggests all is well.

[EDIT: I have just checked and when Folder does NOT contain FH V5 or later Website... is shown the button does nothing, no Progress Bar and no popup, which is a mistake, and is fixed in the ATTACHMENT Zip file below.]
[EDIT: ATTACHMENT Zip file now deleted as a later version is in the Plugin Store.]

[Valkrider]

Mike

It is this bit that I had the issue with:

The files can be downloaded as a zip file from the list below. Unzip the download and copy or move its contents to a subfolder of the path above as identified in the list below.

This indicates to me that you should copy the extracted folder and make it a subfolder of Program Data.

With V2.9.2 the popup now appears as per your screenshot. The tooltips on the tabs are still the same, flashing with yellow backgrounds.

Yes it does say When testing the Media Popups tab does the top pane say The HTML folder is valid...