* AS Data entry not working.

[johnmorrisoniom]

Hi Mike, When the site was down earlier today, your plugin refused to work.
I realise that this is due to the plugin checking version history. But that should just be a warning , not stop it working altogether.

[tatewise]

The Plugin checks two things via the Internet.
(1) The Plugin Store Version to report if a later AS Plugin Version needs downloading.
(2) The FHUG AS Downloads to report if a later AS Program Version needs installing.

But neither should stop the Plugin running if there is no communication.

Perhaps the response from the FHUG server was very slow in some way that prevented the Plugin proceeding.

It is difficult to test these failure modes. If the Internet is simply disconnected it runs fine with just the warning message.

Next time the FHUG site is down I will try to remember to test it.

[Jane]

Mike, the failure yesterday, meant that the server was returning a 404 error rather than timing out, so it might have just been the fact the text you were getting back was not formatted as expected. The plugin checker would have been fine as it's on Calico's server.

I suspect the problem was line 2879

StrASVer = strReturn:match("Ancestral Sources.-([%d%.]+)") -- Extract the Ancestral Sources Version digits & dots

As StrASVer would have been nil when returned as the page being returned did not contain Ancestral Sources

So when it's used for comparison on 2988 it would fail

[tatewise]

Yes, someone else informed me of that 'match' error on line 2988, but John Morrison does not mention an error message, just that the Plugin 'refused to work'.

I can easily fix the 'match' error by changing the line you suggested to:
StrASVer = strReturn:match("Ancestral Sources.-([%d%.]+)") or StrASVer
because StrASVer has a valid AS Version number at that point, but not necessarily the latest.

[johnmorrisoniom]

Hi Mike,
I did get an error message, then the plugin closed without opening AS. I was not in a position to get what the error message was. Sorry if I mislead you.